]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
extensionDownloader: Stop setting proxy resolver explicitly
authorFlorian Müllner <fmuellner@gnome.org>
Tue, 3 Aug 2021 22:24:41 +0000 (00:24 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Tue, 24 Aug 2021 23:54:07 +0000 (01:54 +0200)
Quoting the documentation:

  In libsoup 2.44 and later, you can set the session's “proxy-resolver”
  property to the resolver returned by g_proxy_resolver_get_default() to
  get the same effect. Note that for "plain" SoupSessions (ie, not
  SoupSessionAsync or SoupSessionSync), this is done for you automatically.

libsoup 2.44 was released in 2013, so we can safely assume that Soup is
new enough to handle this for us.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1940>

js/ui/extensionDownloader.js

index 3b64ec4b9c108fe64fa29ce4d3e48347416bdc06..08cea59318e451539065b76382c44ccbdb1777e8 100644 (file)
@@ -253,8 +253,4 @@ class InstallExtensionDialog extends ModalDialog.ModalDialog {
 
 function init() {
     _httpSession = new Soup.Session({ ssl_use_system_ca_file: true });
-
-    // See: https://bugzilla.gnome.org/show_bug.cgi?id=655189 for context.
-    // _httpSession.add_feature(new Soup.ProxyResolverDefault());
-    Soup.Session.prototype.add_feature.call(_httpSession, new Soup.ProxyResolverDefault());
 }